Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc markdown #6605

Merged
merged 3 commits into from
Jan 21, 2021
Merged

Doc markdown #6605

merged 3 commits into from
Jan 21, 2021

Conversation

kawogi
Copy link

@kawogi kawogi commented Jan 17, 2021

I added "WebGL" along the lines of the existing "OpenGL" to the whitelist of doc_markdown as I found this to be a pretty common term.

(this is a follow-up of the now closed #6388)

changelog: Whitelist "WebGL" in doc_markdown.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 17, 2021
@llogiq
Copy link
Contributor

llogiq commented Jan 21, 2021

Thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Jan 21, 2021

📌 Commit c3244c2 has been approved by llogiq

@bors
Copy link
Contributor

bors commented Jan 21, 2021

⌛ Testing commit c3244c2 with merge 4d381c3...

@bors
Copy link
Contributor

bors commented Jan 21, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 4d381c3 to master...

@bors bors merged commit 4d381c3 into rust-lang:master Jan 21, 2021
@kawogi kawogi deleted the doc-markdown branch January 23, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants